Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Remove TMC bootstrap assets #2971

Merged
merged 1 commit into from
Jun 9, 2023
Merged

⚠️ Remove TMC bootstrap assets #2971

merged 1 commit into from
Jun 9, 2023

Conversation

mjudeikis
Copy link
Contributor

@mjudeikis mjudeikis commented Jun 4, 2023 •
edited
Loading

Summary

Removes Locations, Placement, Synctarget related API resources from bootstrap process to avoid unmanaged APIS being present.

part of #2954

Remove TMC APIS from bootstrap process

Related issue(s)

Fixes #

Signed-off-by: mjudeikis [email protected]

@openshift-ci openshift-ci bot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Jun 4, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 4, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sttts for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mjudeikis mjudeikis marked this pull request as draft June 4, 2023 16:36
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 4, 2023
@mjudeikis
Copy link
Contributor Author

/retest

1 similar comment
@mjudeikis
Copy link
Contributor Author

/retest

@mjudeikis mjudeikis marked this pull request as ready for review June 5, 2023 05:53
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 5, 2023
@openshift-ci openshift-ci bot requested review from kylape and qiujian16 June 5, 2023 05:53
@shawn-hurley shawn-hurley removed their request for review June 6, 2023 15:33
@xrstf
Copy link
Contributor

xrstf commented Jun 6, 2023

/test all

@xrstf xrstf closed this Jun 6, 2023
@xrstf xrstf reopened this Jun 6, 2023
@kcp-ci-bot kcp-ci-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. dco-signoff: no Indicates the PR's author has not signed the DCO. labels Jun 6, 2023
@mjudeikis mjudeikis closed this Jun 6, 2023
@mjudeikis mjudeikis reopened this Jun 6, 2023
@kcp-ci-bot kcp-ci-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 6, 2023
@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. and removed dco-signoff: no Indicates the PR's author has not signed the DCO. labels Jun 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 6, 2023

@mjudeikis: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e 3f9d991 link true /test e2e
ci/prow/e2e-shared 3f9d991 link true /test e2e-shared
ci/prow/e2e-sharded 3f9d991 link true /test e2e-sharded
ci/prow/e2e-multiple-runs 3f9d991 link true /test e2e-multiple-runs

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mjudeikis
Copy link
Contributor Author

/retest

@mjudeikis
Copy link
Contributor Author

/override ci/prow/e2e
/override ci/prow/e2e-shared
/override ci/prow/e2e-sharded
/override ci/prow/e2e-multiple-runs

@kcp-ci-bot
Copy link
Contributor

@mjudeikis: mjudeikis unauthorized: /override is restricted to Repo administrators.

In response to this:

/override ci/prow/e2e
/override ci/prow/e2e-shared
/override ci/prow/e2e-sharded
/override ci/prow/e2e-multiple-runs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mjudeikis mjudeikis closed this Jun 7, 2023
@mjudeikis mjudeikis reopened this Jun 7, 2023
@mjudeikis
Remove TMC bootstrap assets
9c76d51 
Signed-off-by: Mangirdas Judeikis <[email protected]>
@mjudeikis mjudeikis force-pushed the clean.tmc.part2 branch 2 times, most recently from 3f9d991 to 8d24717 Compare June 7, 2023 17:50
@mjudeikis
Copy link
Contributor Author

@xrstf @sttts would like some rubber stamp on this :)

xrstf
xrstf approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@xrstf xrstf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2023
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 45950d92f6cff2ca1a7807282e7d812cd56e5308

@sttts
Copy link
Member

sttts commented Jun 9, 2023

/approve
/lgtm

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2023
@kcp-ci-bot kcp-ci-bot merged commit bc275d9 into kcp-dev:main Jun 9, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrstf xrstf xrstf approved these changes

@s-urbaniak s-urbaniak Awaiting requested review from s-urbaniak

@kylape kylape Awaiting requested review from kylape

@qiujian16 qiujian16 Awaiting requested review from qiujian16

Assignees

@xrstf xrstf

@sttts sttts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mjudeikis @xrstf @kcp-ci-bot @sttts