✨ Syncer transfos and coordination controller helpers #2289
Conversation
openshift-ci
bot
added
the
kind/api-change
|
|
||
| func UpstreamViewChanged(old, new Object, equality func(old, new interface{}) bool) bool { | ||
| old = old.DeepCopyObject().(Object) | ||
| new = new.DeepCopyObject().(Object) |
There was a problem hiding this comment.
these are heavy operations. The only thing you mutate are annotations?
There was a problem hiding this comment.
But it's only on helpers for coordination controllers, and isn't involved in the main transformation.
davidfestal
force-pushed
the
syncer-transfos-and-coordination-controller-helpers
branch
from
6828cb0
to
2d619c9
Compare
|
|
||
| // DefaultSummarizingRules provides a default minimal implementation of [SummarizingRules]. | ||
| // It only adds a status field, which for now is always promoted (see comments below in the code) | ||
| type DefaultSummarizingRules struct{} |
There was a problem hiding this comment.
can we then call it as something what it is? AlwaysPromoteStatusFieldSummarizing or similar.
There was a problem hiding this comment.
I'd rather keep this name, because it could probably have additional fields + promottion rules according to the GVR in a near future.
There was a problem hiding this comment.
no strong opinion. Keeping it is fine.
davidfestal
force-pushed
the
syncer-transfos-and-coordination-controller-helpers
branch
3 times, most recently
from
15b698b
to
af2356b
Compare
... using the ResourceTransformer Signed-off-by: David Festal <[email protected]>
... based on the experimental spec-diff annotation Signed-off-by: David Festal <[email protected]>
(experimental and temporary feature) Signed-off-by: David Festal <[email protected]>
Signed-off-by: David Festal <[email protected]>
davidfestal
force-pushed
the
syncer-transfos-and-coordination-controller-helpers
branch
from
af2356b
to
58fb746
Compare
|
/retest |
|
/lgtm |
|
/assign @sttts |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
kcp-ci-bot
added
the
size/XXL
Summary
This PR implements:
This PR is the second part of PROOF PR #1239, which implements the first stories of the EPIC Multi-SyncTarget syncing and coordination controllers.
Thus this PR should be reviewed with the wider context and use-case in mind (especially the deployment Splitter POC in the PROOF PR).
Reviewing this PR commit-by-commit will make it easier.
Related issue(s)
#1992