fixup! pkg: enable conversion strategy in apibinder reconciler to tra…

…nform APIResourceSchema to CRD Signed-off-by: Nabarun Pal <[email protected]>
kcp-dev · Mar 26, 2024 · dd4eb00 · dd4eb00
1 parent e44ab5d
commit dd4eb00
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/pkg/reconciler/apis/apibinding/apibinding_reconcile.go b/pkg/reconciler/apis/apibinding/apibinding_reconcile.go
@@ -551,7 +551,7 @@ func generateCRD(schema *apisv1alpha1.APIResourceSchema) (*apiextensionsv1.Custo
  conversion.Webhook = &apiextensionsv1.WebhookConversion{
  ConversionReviewVersions: schema.Spec.Conversion.Webhook.ConversionReviewVersions,
  ClientConfig: &apiextensionsv1.WebhookClientConfig{
- URL: schema.Spec.Conversion.Webhook.ClientConfig.URL,
+ URL: &(schema.Spec.Conversion.Webhook.ClientConfig.URL),
  CABundle: schema.Spec.Conversion.Webhook.ClientConfig.CABundle,
  },
  }

diff --git a/sdk/apis/apis/v1alpha1/crd_to_apiresourceschema.go b/sdk/apis/apis/v1alpha1/crd_to_apiresourceschema.go
@@ -68,7 +68,7 @@ func CRDToAPIResourceSchema(crd *apiextensionsv1.CustomResourceDefinition, prefi
 
  if crd.Spec.Conversion.Webhook.ClientConfig != nil {
  crConversion.Webhook.ClientConfig = &WebhookClientConfig{
- URL: crd.Spec.Conversion.Webhook.ClientConfig.URL,
+ URL: *crd.Spec.Conversion.Webhook.ClientConfig.URL,
  CABundle: crd.Spec.Conversion.Webhook.ClientConfig.CABundle,
  }
  }