runtime: Enable connection to Quote Generation Service (QGS) #9653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am setting this to "Ready to Review" as I was able to check that both Ubuntu and CentOS are using exactly the very same command line for QEMU, which is great, and avoids us to do any kind of distro check on the runtime side. |
fidencio
requested changes
May 20, 2024
There was a problem hiding this comment.
I've left one comment, apart from the comment, everything looks good, thanks @JakubLedworowski!
JakubLedworowski
force-pushed
the
fixes-9497-ensure-quote-generation-service-is-added-to-qemu-cmd-2
branch
from
7de53c6
to
b4f5a6a
Compare
|
/test |
katacontainersbot
added
size/large
JakubLedworowski
force-pushed
the
fixes-9497-ensure-quote-generation-service-is-added-to-qemu-cmd-2
branch
from
299a06c
to
f544438
Compare
katacontainersbot
added
size/medium
|
/test |
For the TD attestation to work the connection to QGS on the host is needed.
By default QGS runs on vsock port 4050, but can be modified by the host owner.
Format of the qemu object follows the SocketAddress structure, so it needs to be provided in the JSON format, as in the example below:
-object '{"qom-type":"tdx-guest","id":"tdx","quote-generation-socket":{"type":"vsock","cid":"2","port":"4050"}}'
Fixes: kata-containers#9497
Signed-off-by: Jakub Ledworowski <[email protected]>
JakubLedworowski
force-pushed
the
fixes-9497-ensure-quote-generation-service-is-added-to-qemu-cmd-2
branch
from
f544438
to
fc68013
Compare
fidencio
approved these changes
May 22, 2024
|
/test |
chavafg
approved these changes
May 22, 2024
JakubLedworowski
deleted the
fixes-9497-ensure-quote-generation-service-is-added-to-qemu-cmd-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the TD attestation to work the connection to QGS on the host is needed. By default QGS runs on vsock port 4050, but can be modified by the host owner. Format of the qemu object follows the SocketAddress structure, so it needs to be provided in the JSON format, as in the example below: -object '{"qom-type":"tdx-guest","id":"tdx","quote-generation-socket":{"type":"vsock","cid":"2","port":"4050"}}'
Fixes: #9497