Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fody to replace ILRepack #420

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Use fody to replace ILRepack #420

wants to merge 5 commits into from

Conversation

andy840119
Copy link
Member

Fix ILRepack not working in .net5 #413
.
Do the same things follow gamebosu
Still no idea why not working.

@andy840119 andy840119 added the updates Update any package label Jan 18, 2021
@andy840119 andy840119 self-assigned this Jan 18, 2021
@andy840119
Copy link
Member Author

packed size should be 2~3MB

@andy840119
Copy link
Member Author

Get confuse between Costura and ILmerge.fody
Ass

@andy840119 andy840119 marked this pull request as draft January 19, 2021 02:05
@andy840119
Copy link
Member Author

But seems gamebosu works
Maybe try to re-open visual studio🤔

@andy840119
Copy link
Member Author

Seems like should use ILMerge
But got no idea why it can't work with nuget(might cause nuget dll is not in bin\Release\netstandard2.1 so fody cannot find it)?

@andy840119 andy840119 force-pushed the use-fody-instead-of-ilmerge branch from cf103cf to 913349a Compare January 20, 2021 02:27
@andy840119
Copy link
Member Author

Also notice that this will cause error, and it only happens in osu.Framework.KaraokeFont

/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/IO/Serialization/Converters/TimeTagConverterTest.cs(20,46): error CS0433: The type 'TextIndex' exists in both 'osu.Framework.KaraokeFont, Version=1.6.1.0, Culture=neutral, PublicKeyToken=null' and 'osu.Game.Rulesets.Karaoke, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' [/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/osu.Game.Rulesets.Karaoke.Tests.csproj]
/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/IO/Serialization/Converters/TimeTagConverterTest.cs(38,61): error CS0433: The type 'TextIndex' exists in both 'osu.Framework.KaraokeFont, Version=1.6.1.0, Culture=neutral, PublicKeyToken=null' and 'osu.Game.Rulesets.Karaoke, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' [/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/osu.Game.Rulesets.Karaoke.Tests.csproj]
/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/IO/Serialization/Converters/TimeTagConverterTest.cs(15,22): error CS0433: The type 'TextIndex' exists in both 'osu.Framework.KaraokeFont, Version=1.6.1.0, Culture=neutral, PublicKeyToken=null' and 'osu.Game.Rulesets.Karaoke, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' [/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/osu.Game.Rulesets.Karaoke.Tests.csproj]
/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/IO/Serialization/Converters/TimeTagConverterTest.cs(16,22): error CS0433: The type 'TextIndex' exists in both 'osu.Framework.KaraokeFont, Version=1.6.1.0, Culture=neutral, PublicKeyToken=null' and 'osu.Game.Rulesets.Karaoke, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' [/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/osu.Game.Rulesets.Karaoke.Tests.csproj]
/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/IO/Serialization/Converters/TimeTagConverterTest.cs(17,23): error CS0433: The type 'TextIndex' exists in both 'osu.Framework.KaraokeFont, Version=1.6.1.0, Culture=neutral, PublicKeyToken=null' and 'osu.Game.Rulesets.Karaoke, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' [/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/osu.Game.Rulesets.Karaoke.Tests.csproj]
/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/IO/Serialization/Converters/TimeTagConverterTest.cs(18,22): error CS0433: The type 'TextIndex' exists in both 'osu.Framework.KaraokeFont, Version=1.6.1.0, Culture=neutral, PublicKeyToken=null' and 'osu.Game.Rulesets.Karaoke, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' [/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/osu.Game.Rulesets.Karaoke.Tests.csproj]
/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/IO/Serialization/Converters/TimeTagConverterTest.cs(19,22): error CS0433: The type 'TextIndex' exists in both 'osu.Framework.KaraokeFont, Version=1.6.1.0, Culture=neutral, PublicKeyToken=null' and 'osu.Game.Rulesets.Karaoke, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' [/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/osu.Game.Rulesets.Karaoke.Tests.csproj]
/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/Utils/TextIndexUtilsTest.cs(17,49): error CS0433: The type 'TextIndex' exists in both 'osu.Framework.KaraokeFont, Version=1.6.1.0, Culture=neutral, PublicKeyToken=null' and 'osu.Game.Rulesets.Karaoke, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' [/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/osu.Game.Rulesets.Karaoke.Tests.csproj]
/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/Utils/TextIndexUtilsTest.cs(25,38): error CS0433: The type 'TextIndex' exists in both 'osu.Framework.KaraokeFont, Version=1.6.1.0, Culture=neutral, PublicKeyToken=null' and 'osu.Game.Rulesets.Karaoke, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' [/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/osu.Game.Rulesets.Karaoke.Tests.csproj]
/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/Utils/TextIndexUtilsTest.cs(25,66): error CS0433: The type 'TextIndex' exists in both 'osu.Framework.KaraokeFont, Version=1.6.1.0, Culture=neutral, PublicKeyToken=null' and 'osu.Game.Rulesets.Karaoke, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' [/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/osu.Game.Rulesets.Karaoke.Tests.csproj]
/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/Utils/TextIndexUtilsTest.cs(34,50): error CS0433: The type 'TextIndex' exists in both 'osu.Framework.KaraokeFont, Version=1.6.1.0, Culture=neutral, PublicKeyToken=null' and 'osu.Game.Rulesets.Karaoke, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' [/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/osu.Game.Rulesets.Karaoke.Tests.csproj]
/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/Utils/TextIndexUtilsTest.cs(34,109): error CS0433: The type 'TextIndex' exists in both 'osu.Framework.KaraokeFont, Version=1.6.1.0, Culture=neutral, PublicKeyToken=null' and 'osu.Game.Rulesets.Karaoke, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' [/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/osu.Game.Rulesets.Karaoke.Tests.csproj]
/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/Utils/TextIndexUtilsTest.cs(13,22): error CS0433: The type 'TextIndex' exists in both 'osu.Framework.KaraokeFont, Version=1.6.1.0, Culture=neutral, PublicKeyToken=null' and 'osu.Game.Rulesets.Karaoke, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' [/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/osu.Game.Rulesets.Karaoke.Tests.csproj]
/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/Utils/TextIndexUtilsTest.cs(14,22): error CS0433: The type 'TextIndex' exists in both 'osu.Framework.KaraokeFont, Version=1.6.1.0, Culture=neutral, PublicKeyToken=null' and 'osu.Game.Rulesets.Karaoke, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' [/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/osu.Game.Rulesets.Karaoke.Tests.csproj]
/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/Utils/TextIndexUtilsTest.cs(15,23): error CS0433: The type 'TextIndex' exists in both 'osu.Framework.KaraokeFont, Version=1.6.1.0, Culture=neutral, PublicKeyToken=null' and 'osu.Game.Rulesets.Karaoke, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' [/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/osu.Game.Rulesets.Karaoke.Tests.csproj]
/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/Utils/TextIndexUtilsTest.cs(16,23): error CS0433: The type 'TextIndex' exists in both 'osu.Framework.KaraokeFont, Version=1.6.1.0, Culture=neutral, PublicKeyToken=null' and 'osu.Game.Rulesets.Karaoke, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' [/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/osu.Game.Rulesets.Karaoke.Tests.csproj]
/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/Utils/TextIndexUtilsTest.cs(23,19): error CS0433: The type 'TextIndex' exists in both 'osu.Framework.KaraokeFont, Version=1.6.1.0, Culture=neutral, PublicKeyToken=null' and 'osu.Game.Rulesets.Karaoke, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' [/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/osu.Game.Rulesets.Karaoke.Tests.csproj]
/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/Utils/TextIndexUtilsTest.cs(23,47): error CS0433: The type 'TextIndex' exists in both 'osu.Framework.KaraokeFont, Version=1.6.1.0, Culture=neutral, PublicKeyToken=null' and 'osu.Game.Rulesets.Karaoke, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' [/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/osu.Game.Rulesets.Karaoke.Tests.csproj]
/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/Utils/TextIndexUtilsTest.cs(24,19): error CS0433: The type 'TextIndex' exists in both 'osu.Framework.KaraokeFont, Version=1.6.1.0, Culture=neutral, PublicKeyToken=null' and 'osu.Game.Rulesets.Karaoke, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' [/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/osu.Game.Rulesets.Karaoke.Tests.csproj]
/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/Utils/TextIndexUtilsTest.cs(24,45): error CS0433: The type 'TextIndex' exists in both 'osu.Framework.KaraokeFont, Version=1.6.1.0, Culture=neutral, PublicKeyToken=null' and 'osu.Game.Rulesets.Karaoke, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' [/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/osu.Game.Rulesets.Karaoke.Tests.csproj]
/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/IO/Serialization/Converters/TimeTagConverterTest.cs(28,40): error CS0433: The type 'TextIndex' exists in both 'osu.Framework.KaraokeFont, Version=1.6.1.0, Culture=neutral, PublicKeyToken=null' and 'osu.Game.Rulesets.Karaoke, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' [/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/osu.Game.Rulesets.Karaoke.Tests.csproj]
/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/IO/Serialization/Converters/TimeTagConverterTest.cs(29,38): error CS0433: The type 'TextIndex' exists in both 'osu.Framework.KaraokeFont, Version=1.6.1.0, Culture=neutral, PublicKeyToken=null' and 'osu.Game.Rulesets.Karaoke, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' [/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/osu.Game.Rulesets.Karaoke.Tests.csproj]
/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/IO/Serialization/Converters/TimeTagConverterTest.cs(30,42): error CS0433: The type 'TextIndex' exists in both 'osu.Framework.KaraokeFont, Version=1.6.1.0, Culture=neutral, PublicKeyToken=null' and 'osu.Game.Rulesets.Karaoke, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' [/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/osu.Game.Rulesets.Karaoke.Tests.csproj]
/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/IO/Serialization/Converters/TimeTagConverterTest.cs(31,41): error CS0433: The type 'TextIndex' exists in both 'osu.Framework.KaraokeFont, Version=1.6.1.0, Culture=neutral, PublicKeyToken=null' and 'osu.Game.Rulesets.Karaoke, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' [/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/osu.Game.Rulesets.Karaoke.Tests.csproj]
/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/IO/Serialization/Converters/TimeTagConverterTest.cs(32,36): error CS0433: The type 'TextIndex' exists in both 'osu.Framework.KaraokeFont, Version=1.6.1.0, Culture=neutral, PublicKeyToken=null' and 'osu.Game.Rulesets.Karaoke, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' [/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/osu.Game.Rulesets.Karaoke.Tests.csproj]
/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/IO/Serialization/Converters/TimeTagConverterTest.cs(33,26): error CS0433: The type 'TextIndex' exists in both 'osu.Framework.KaraokeFont, Version=1.6.1.0, Culture=neutral, PublicKeyToken=null' and 'osu.Game.Rulesets.Karaoke, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' [/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/osu.Game.Rulesets.Karaoke.Tests.csproj]
/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/IO/Serialization/Converters/TimeTagConverterTest.cs(34,34): error CS0433: The type 'TextIndex' exists in both 'osu.Framework.KaraokeFont, Version=1.6.1.0, Culture=neutral, PublicKeyToken=null' and 'osu.Game.Rulesets.Karaoke, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' [/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/osu.Game.Rulesets.Karaoke.Tests.csproj]
/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/IO/Serialization/Converters/TimeTagConverterTest.cs(35,30): error CS0433: The type 'TextIndex' exists in both 'osu.Framework.KaraokeFont, Version=1.6.1.0, Culture=neutral, PublicKeyToken=null' and 'osu.Game.Rulesets.Karaoke, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' [/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/osu.Game.Rulesets.Karaoke.Tests.csproj]
/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/IO/Serialization/Converters/TimeTagConverterTest.cs(36,34): error CS0433: The type 'TextIndex' exists in both 'osu.Framework.KaraokeFont, Version=1.6.1.0, Culture=neutral, PublicKeyToken=null' and 'osu.Game.Rulesets.Karaoke, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' [/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/osu.Game.Rulesets.Karaoke.Tests.csproj]
/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/IO/Serialization/Converters/TimeTagConverterTest.cs(37,28): error CS0433: The type 'TextIndex' exists in both 'osu.Framework.KaraokeFont, Version=1.6.1.0, Culture=neutral, PublicKeyToken=null' and 'osu.Game.Rulesets.Karaoke, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' [/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/osu.Game.Rulesets.Karaoke.Tests.csproj]
/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/Utils/TimeTagsUtilsTest.cs(152,60): error CS0433: The type 'TextIndex' exists in both 'osu.Framework.KaraokeFont, Version=1.6.1.0, Culture=neutral, PublicKeyToken=null' and 'osu.Game.Rulesets.Karaoke, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' [/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/osu.Game.Rulesets.Karaoke.Tests.csproj]
/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/Utils/TextIndexUtilsTest.cs(30,22): error CS0433: The type 'TextIndex' exists in both 'osu.Framework.KaraokeFont, Version=1.6.1.0, Culture=neutral, PublicKeyToken=null' and 'osu.Game.Rulesets.Karaoke, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' [/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/osu.Game.Rulesets.Karaoke.Tests.csproj]
/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/Utils/TextIndexUtilsTest.cs(30,56): error CS0433: The type 'TextIndex' exists in both 'osu.Framework.KaraokeFont, Version=1.6.1.0, Culture=neutral, PublicKeyToken=null' and 'osu.Game.Rulesets.Karaoke, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' [/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/osu.Game.Rulesets.Karaoke.Tests.csproj]
/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/Utils/TextIndexUtilsTest.cs(31,22): error CS0433: The type 'TextIndex' exists in both 'osu.Framework.KaraokeFont, Version=1.6.1.0, Culture=neutral, PublicKeyToken=null' and 'osu.Game.Rulesets.Karaoke, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' [/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/osu.Game.Rulesets.Karaoke.Tests.csproj]
/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/Utils/TextIndexUtilsTest.cs(31,54): error CS0433: The type 'TextIndex' exists in both 'osu.Framework.KaraokeFont, Version=1.6.1.0, Culture=neutral, PublicKeyToken=null' and 'osu.Game.Rulesets.Karaoke, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' [/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/osu.Game.Rulesets.Karaoke.Tests.csproj]
/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/Utils/TextIndexUtilsTest.cs(32,22): error CS0433: The type 'TextIndex' exists in both 'osu.Framework.KaraokeFont, Version=1.6.1.0, Culture=neutral, PublicKeyToken=null' and 'osu.Game.Rulesets.Karaoke, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' [/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/osu.Game.Rulesets.Karaoke.Tests.csproj]
/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/Utils/TextIndexUtilsTest.cs(32,58): error CS0433: The type 'TextIndex' exists in both 'osu.Framework.KaraokeFont, Version=1.6.1.0, Culture=neutral, PublicKeyToken=null' and 'osu.Game.Rulesets.Karaoke, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' [/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/osu.Game.Rulesets.Karaoke.Tests.csproj]
/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/Utils/TextIndexUtilsTest.cs(33,22): error CS0433: The type 'TextIndex' exists in both 'osu.Framework.KaraokeFont, Version=1.6.1.0, Culture=neutral, PublicKeyToken=null' and 'osu.Game.Rulesets.Karaoke, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' [/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/osu.Game.Rulesets.Karaoke.Tests.csproj]
/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/Utils/TextIndexUtilsTest.cs(33,56): error CS0433: The type 'TextIndex' exists in both 'osu.Framework.KaraokeFont, Version=1.6.1.0, Culture=neutral, PublicKeyToken=null' and 'osu.Game.Rulesets.Karaoke, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null' [/Users/andy840119/Documents/Github/andy840119/karaoke/osu.Game.Rulesets.Karaoke.Tests/osu.Game.Rulesets.Karaoke.Tests.csproj]
    0 Warning(s)
    39 Error(s)

Time Elapsed 00:00:15.05
 ✘ andy840119@koushinadaiMacbook  ~/Documents/Github/andy840119/karaoke   use-fody-instead-of-ilmerge 

And the reason might because it's only osu.Framework.KaraokeFont use in test case project.

@andy840119
Copy link
Member Author

maybe should let fody ignore version (e.g: should be 1.0.0.0)?

@andy840119 andy840119 mentioned this pull request Jan 20, 2021
Draft
@andy840119
Copy link
Member Author

maybe try fullimport to default or true?
https://github.com/tom-englert/ILMerge.Fody#fullimport

@andy840119
Copy link
Member Author

andy840119 commented Jan 21, 2021 •
edited
Loading

I got the point.
Because it'll replace exist dll.
Should be able to assign target export name and not override exist one.
Like osu.Game.Rulesets.Karaoke.packed.dll

@andy840119 andy840119 force-pushed the use-fody-instead-of-ilmerge branch from 913349a to 5efb325 Compare May 2, 2021 12:50
@andy840119 andy840119 force-pushed the use-fody-instead-of-ilmerge branch 2 times, most recently from 95d81a8 to 66e2746 Compare February 7, 2022 17:16
@andy840119
Copy link
Member Author

update to the latest version.
Got no idea why cannot load into the lazer.

@andy840119 andy840119 added the ILMerge Got no idea why there's so much merge tools i need to try. label Feb 8, 2022
@andy840119
Copy link
Member Author

andy840119 commented Feb 8, 2022 •
edited
Loading

update:
will got the error if pack all the package:

  Fody: An unhandled exception occurred:
Exception:
Failed to execute weaver /Users/andy840119/.nuget/packages/ilmerge.fody/1.22.0/build/../weaver/ILMerge.Fody.dll
Type:
System.Exception
StackTrace:
   at InnerWeaver.ExecuteWeavers() in C:\projects\fody\FodyIsolated\InnerWeaver.cs:line 221
   at InnerWeaver.Execute() in C:\projects\fody\FodyIsolated\InnerWeaver.cs:line 111
Source:
FodyIsolated
TargetSite:
Void ExecuteWeavers()
IL Import failed: SixLabors.Guard already exists in target module.
Type:
System.InvalidOperationException
StackTrace:
   at FodyTools.CodeImporter.ImportTypeDefinition(TypeDefinition sourceType)
   at FodyTools.CodeImporter.CloneInstruction(Instruction source, MethodDefinition targetMethod, IReadOnlyDictionary`2 instructionMap)
   at FodyTools.CodeImporter.CopyInstructions(MethodDefinition source, MethodDefinition target)
   at FodyTools.CodeImporter.<>c__DisplayClass59_0.<ImportMethodBody>b__0()
   at FodyTools.CodeImporter.ProcessDeferredActions[T](T target)
   at FodyTools.CodeImporterExtensions.MergeMethodReference(CodeImporter codeImporter, MethodReference methodReference, MethodDefinition methodDefinition)
   at FodyTools.CodeImporterExtensions.ILMerge(CodeImporter codeImporter)
   at ILMerge.Fody.ModuleWeaver.Execute()
   at InnerWeaver.ExecuteWeavers() in C:\projects\fody\FodyIsolated\InnerWeaver.cs:line 185
Source:
ILMerge.Fody
TargetSite:
Mono.Cecil.TypeDefinition ImportTypeDefinition(Mono.Cecil.TypeDefinition)

still not working in dotnet 6.0
not working in the windows.

@andy840119 andy840119 force-pushed the use-fody-instead-of-ilmerge branch from 66e2746 to 8dcbac9 Compare February 16, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@andy840119 andy840119

Labels
ILMerge Got no idea why there's so much merge tools i need to try. size/M updates Update any package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andy840119