New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use command pattern to update the lyric style. #2314

Merged

andy840119 merged 13 commits into karaoke-dev:master from andy840119:migrate-lyric-style-into-stage

Dec 11, 2024

Member

andy840119 commented Dec 11, 2024

Start moving complex code out of the skin.

andy840119 added 13 commits

December 10, 2024 22:00


          refactor(code): P0.1 - Rename the params.

b7554cc


          chore(stage): P0.2 - stage category should be able to create its own …

a3ca3c2

…default element.


          feat(sprite): P1.1 - Create method for update the style.

52b77e2

merge.


          feat(stage): P1.2 - Implement the transformer.

be51f67


          feat(stage): P1.3 - Replace the object id into class instance. Also, …

d12293d

…give the category a default value.


          feat(stage): P1.4 - Apply the style to the provider.

64442db


          fix(drawable): P2.1 - Change the singer should not affect the style.

65ba7f5


          fix(drawable): P2.2 - Give this font a default style.

7553a3f


          chore(skin): P2.3 - remove the enum.

ae8e896


          chore(skin): P2.4 - Remove the style manager.

1f99ef9


          chore(skin): P2.5 - Remove the definition from skin element.

416ca3e


          chore(test): P3.1 - Remove unnecessary test case.

d17bddd


          chore(test): P3.2 - Remove static resource.

3c68ed3

andy840119 added the Stage label

andy840119 added this to the 2025.0202 milestone

pull-request-size bot added the size/L label

andy840119 mentioned this pull request

Move drawable hit-object adjustment from skin/ ruleset configuration to stage and mod. #2306

Open

andy840119 merged commit c41d65b into karaoke-dev:master

3 of 5 checks passed

andy840119 deleted the migrate-lyric-style-into-stage branch

December 11, 2024 00:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels