Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define the interface for mod to modify the stage. #2310

Merged

Conversation

andy840119
Copy link
Member

Some of the styles are affected by ruleset configuration and skin.
For example, DrawableLyric reads the fontInfo from ruleset config and applies the change directly.

After all style-related property should be adjust by command, should changed to:

  1. create a default command for each stage info.
  2. If want to override the default font, should create a mod that can read the ruleset configuration, and generate the command by the mod.

@andy840119 andy840119 added this to the 2025.0202 milestone Dec 7, 2024
@andy840119 andy840119 added Stage Anything about any kinds of stage. and removed size/L labels Dec 7, 2024
@andy840119 andy840119 merged commit e6c0f71 into karaoke-dev:master Dec 7, 2024
3 of 5 checks passed
@andy840119 andy840119 deleted the implement-stage-interface-for-mod branch December 7, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Stage Anything about any kinds of stage.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant