Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BeatmapEditorRoundedScreen #2105

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Joehuu
Copy link
Contributor

@Joehuu Joehuu commented Aug 27, 2023

@andy840119
Copy link
Member

image

I guess i should apprvoe this PR until official editor is more complete.
Because some of the editor looks weird if display in the full-screen. It's hard for me to point-out the reason and find a way to adjust that 😢

@andy840119
Copy link
Member

And if you are interested in contributing to this project, i can filter the issue and pick-up the suitable one for you(because some of the issues is a memo for me and might be hard to see the priority)

@Joehuu Joehuu changed the title Remove BeatmapEditorRoundedScreen Remove BeatmapEditorRoundedScreen Aug 27, 2023
@Joehuu
Copy link
Contributor Author

Joehuu commented Aug 27, 2023

Because some of the editor looks weird if display in the full-screen. It's hard for me to point-out the reason and find a way to adjust that 😢

The change is to mostly match the current design state of the official editor. I do agree that some screens look weird because they are mostly blank / have no content yet (even in the official editor), and making it fullscreen (and hiding the beatmap background) doesn't make it better.

Can wait, it's just a cosmetic change.

And if you are interested in contributing to this project, i can filter the issue and pick-up the suitable one for you(because some of the issues is a memo for me and might be hard to see the priority)

I just want to clean up the issues right now by targeting the easier ones first (even if it's low priority). That would be code quality, design, bug/crashes, etc.

I don't want to be recommended an issue up front, but I would appreciate priority:1|2|3 or similar labels like osu! so I can get a sense of what the current goals are and contribute to something bigger when I get the chance.

@andy840119
Copy link
Member

andy840119 commented Aug 27, 2023

I don't want to be recommended an issue up front, but I would appreciate priority:1|2|3 or similar labels like osu! so I can get a sense of what the current goals are and contribute to something bigger when I get the chance.

I'm not sure using priority flag is a good idea because:

  1. the main contributor for this project is only me ;_;
  2. this project does not have much users right now(means there's no s1 issue), so priority is decided by what i'm doing right now and might be changed frequently.

I guess using Good for contributor Those issues does not UX or behavior-related, so did not need lots of discussion. flag might be better right now, you can pick-up the issue with this label, and feel free to ask me if have any question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove KaraokeEditorRoundedScreen screen.
2 participants