Separate the working property. #2091
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
想清楚後再決定要不要 merge. 還有需要想想不合併會怎樣 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark as part of #2090.
目前希望 stageInfo 也能有自己的 processor.
第一個目標是把 ValidateWorkingProperty 分開
讓 beatmap processor / stage info processor 能夠分別丟入 karaoke beatmap / stage info 來把 lyric/note 的 working property 補上值
以 lyric 舉例
目前所有的 working property type 都是放在同一個 enum 中
但會有一個缺點，需要呼叫ValidateWorkingProperty(beatmap) + ValidateWorkingProperty(stage) 才能把所有的 working property 都補上值
有一個想法，是不同種類的 working property (beatmap / stage) 應該都要有自己的 enum，有一些好處:
Notion:
https://karaoke-dev.notion.site/HitObject-working-property-f269d04837a14000a2a21e03c1a8c8d0?pvs=4
先記錄在這邊，想好後再開始處理這隻 PR