Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving the resource file into another dll #1367

Merged
merged 7 commits into from
Jun 11, 2022

Conversation

andy840119
Copy link
Member

@andy840119 andy840119 commented Jun 8, 2022

What's done in this PR:

  • Create resource dll for the current ruleset, see: https://github.com/karaoke-dev/karaoke-resources
  • Install the package.
  • Remove localization resource.
  • Remove image resource.
  • Fix not loading the resource file. We need to make sure that resource file in the main dll and resource dll loaded in the debug and release build.

Check list:

  • Localization loaded in the local and release build.
  • Image and karaoke icon loaded in the local and release build.
  • Skin json file loaded in the local and release build.
  • Remove the crowdin.yml in the root folder create in the Interact with localizaton #1266
  • Remove the crowdin.yml in the CODEOWNER.

Known issues:

@andy840119 andy840119 added updates Update any package skin About skin resource ILMerge Got no idea why there's so much merge tools i need to try. localization Translation related. labels Jun 8, 2022
@andy840119 andy840119 force-pushed the use-the-resource-package branch from 5df8fc3 to 3699737 Compare June 10, 2022 12:04
@andy840119 andy840119 force-pushed the use-the-resource-package branch from 3699737 to 6bd16b0 Compare June 11, 2022 01:48
@andy840119 andy840119 marked this pull request as ready for review June 11, 2022 01:52
@andy840119
Copy link
Member Author

Guess it's perfect enough to make the merge.

@andy840119
Copy link
Member Author

Make a tag release to test this shit.

@andy840119 andy840119 merged commit 4c7ee34 into karaoke-dev:master Jun 11, 2022
@andy840119 andy840119 deleted the use-the-resource-package branch June 11, 2022 02:00
@andy840119 andy840119 added this to the 2022.0625 milestone Jun 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ILMerge Got no idea why there's so much merge tools i need to try. localization Translation related. size/XL skin About skin resource updates Update any package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant