Skip to content

Commit

Permalink
Upgrade the package to the latest.
Browse files Browse the repository at this point in the history
Also, follow https://github.com/ppy/osu/pull/29564/files to fix the skin breaking change.
  • Loading branch information
andy840119 committed Sep 6, 2024
1 parent 365588a commit 2c8820a
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion osu.Game.Rulesets.Karaoke/KaraokeSkinComponentLookup.cs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

namespace osu.Game.Rulesets.Karaoke;

public class KaraokeSkinComponentLookup : GameplaySkinComponentLookup<KaraokeSkinComponents>
public class KaraokeSkinComponentLookup : SkinComponentLookup<KaraokeSkinComponents>
{
public KaraokeSkinComponentLookup(KaraokeSkinComponents component)
: base(component)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,14 @@ public KaraokeDefaultSkinTransformer(ISkin skin, IBeatmap beatmap)
{
switch (lookup)
{
case SkinComponentsContainerLookup containerLookup:
case GlobalSkinnableContainerLookup containerLookup:
// Only handle ruleset level defaults for now.
if (containerLookup.Ruleset == null)
return base.GetDrawableComponent(lookup);

switch (containerLookup.Target)
switch (containerLookup.Lookup)
{
case SkinComponentsContainerLookup.TargetArea.MainHUDComponents:
case GlobalSkinnableContainers.MainHUDComponents:
// see the fall-back strategy in the SkinManager.AllSources.
// will receive the:
// 1. Legacy beatmap skin.
Expand All @@ -59,7 +59,7 @@ public KaraokeDefaultSkinTransformer(ISkin skin, IBeatmap beatmap)

return component;

case SkinComponentsContainerLookup.TargetArea.SongSelect:
case GlobalSkinnableContainers.SongSelect:
default:
return base.GetDrawableComponent(lookup);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public KaraokeLegacySkinTransformer(ISkin skin, IBeatmap beatmap)
{
switch (lookup)
{
case GameplaySkinComponentLookup<HitResult> resultComponent:
case SkinComponentLookup<HitResult> resultComponent:
return getResult(resultComponent.Component);

case KaraokeSkinComponentLookup karaokeComponent:
Expand Down
2 changes: 1 addition & 1 deletion osu.Game.Rulesets.Karaoke/osu.Game.Rulesets.Karaoke.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="ppy.osu.Game" Version="2024.816.0" />
<PackageReference Include="ppy.osu.Game" Version="2024.906.1" />
<PackageReference Include="Lucene.Net" Version="4.8.0-beta00016" />
<PackageReference Include="Lucene.Net.Analysis.Kuromoji" Version="4.8.0-beta00016" />
<PackageReference Include="SixLabors.Fonts" Version="2.0.4" />
Expand Down

0 comments on commit 2c8820a

Please sign in to comment.