Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Failed to add ruleset osu.Game.Rulesets.Karaoke.Resources" error in the local run. #9

Open
andy840119 opened this issue Jun 8, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@andy840119
Copy link
Member

It's caused by the dll name start with osu.Game.Rulesets.
See the RulesetStore in the osu.game.

public abstract class RulesetStore : IDisposable, IRulesetStore
{
    private const string ruleset_library_prefix = @"osu.Game.Rulesets";'
...

Here's the log:

2022-06-08 14:38:10 [verbose]: ⚠️ Failed to add ruleset osu.Game.Rulesets.Karaoke.Resources, Version=2022.608.1.0, Culture=neutral, PublicKeyToken=null
2022-06-08 14:38:10 [verbose]: 
2022-06-08 14:38:10 [verbose]: This error has been automatically reported to the devs.
2022-06-08 14:38:10 [verbose]: ⚠️ Failed to add ruleset osu.Game.Rulesets.Karaoke.Resources, Version=2022.608.1.0, Culture=neutral, PublicKeyToken=null
2022-06-08 14:38:10 [verbose]: 
2022-06-08 14:38:10 [verbose]: This error has been automatically reported to the devs.
2022-06-08 14:38:10 [verbose]: ⚠️ Click to resume first-run setup at any point
2022-06-08 14:38:11 [debug]: Focus changed from nothing to NotificationOverlay.
2022-06-08 14:38:12 [debug]: MouseDownEvent(Left) handled by NotificationOverlay.
2022-06-08 14:38:12 [debug]: ClickEvent(Left) handled by SimpleErrorNotification.
2022-06-08 14:38:12 [debug]: MouseClick handled by SimpleErrorNotification.
2022-06-08 14:38:15 [debug]: MouseDownEvent(Left) handled by NotificationOverlay.
2022-06-08 14:38:15 [debug]: Focus changed from NotificationOverlay to nothing.
2022-06-08 14:38:15 [debug]: MouseDownEvent(Left) handled by OsuLogo.
2022-06-08 14:38:15 [verbose]: ButtonSystem's state changed from Initial to TopLevel
2022-06-08 14:38:15 [debug]: ClickEvent(Left) handled by OsuLogo.
2022-06-08 14:38:15 [debug]: MouseClick handled by OsuLogo.
2022-06-08 14:38:16 [debug]: Focus changed from nothing to LoginForm.
2022-06-08 14:38:16 [debug]: Focus changed from LoginForm to LoginPanel.
2022-06-08 14:38:16 [debug]: Focus changed from LoginPanel to LoginForm.
2022-06-08 14:38:16 [debug]: Focus changed from LoginForm to OsuTextBox.
2022-06-08 14:38:16 [debug]: MouseDownEvent(Left) handled by LoginOverlay.
2022-06-08 14:38:16 [debug]: Focus changed from OsuTextBox to nothing.
2022-06-08 14:38:16 [debug]: ClickEvent(Left) handled by MainMenuButton.
2022-06-08 14:38:16 [debug]: MouseClick handled by MainMenuButton.
2022-06-08 14:38:16 [debug]: Focus changed from nothing to SeekLimitedSearchTextBox.
2022-06-08 14:38:20 [debug]: MouseDownEvent(Left) handled by SettingsOverlay.
2022-06-08 14:38:20 [debug]: ClickEvent(Left) handled by SettingsButton.
2022-06-08 14:38:20 [debug]: MouseClick handled by SettingsButton.
@andy840119 andy840119 added the bug Something isn't working label Jun 8, 2022
@andy840119
Copy link
Member Author

And notice that it will only caused in the local.
Because it will be packed into single dll in the release build.

@andy840119 andy840119 changed the title Failed to add ruleset osu.Game.Rulesets.Karaoke.Resources issue. Fix "Failed to add ruleset osu.Game.Rulesets.Karaoke.Resources" error in the local run. Jun 8, 2022
@andy840119
Copy link
Member Author

Not a big deal, just annoying.

@andy840119
Copy link
Member Author

Not really sure will it be a good idea to place something like FakeRuleset in this repo?
Anyway, the FakeRuleset will not be found in the release build, i guess?

See RulesetStore in the osu.game

try
{
    LoadedAssemblies[assembly] = assembly.GetTypes().First(t => t.IsPublic && t.IsSubclassOf(typeof(Ruleset)));
}
catch (Exception e)
{
    Logger.Error(e, $"Failed to add ruleset {assembly}");
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant