Single word correction (Zl
) can fail without &wrapscan
#86
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to repro
Run
Zl
at the pos below:It happens if
&wrapscan
is disabled (set nowrapscan
)Why this happens
In single word correction in
spelunker#words#replace_word()
,it does
/SERCHWORD/
,N
(move to previous word), and change the target word.With
&wrapscan
(successful case),it does
/SEARCHWORD/
to move the next word, and comes back to the target word byN
.Without
&wrapscan
(bad case),since the target word is the last appearance in the buf,
the
/SEARCHWORD/
command fails, and cursor keeps its position.So, if the cursor is on the beggining of the word,
the following
N
command jumps to the word before the target unexpectedly.To fix this instantly, set
&wrapscan
in the operation.