Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Set spellcheck highlighting on every spellcheck enabling #70

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

KSR-Yasuda
Copy link

Care for #63.

Unknown why, sometimes spellcheck highlight SpelunkerSpellBad and SpelunkerComplexOrCompoundWord can be cleared.

So, changed to set the highlightings on every spellcheck enabling.

Also, consider highlight cleared case (e.g. :highlight clear SpelunkerSpellBad called by someone).
The original code checks whether :highlight SpelunkerSpellBad output something, though,
if highlight is cleared, it outputs SpelunkerSpellBad xxx cleared.

With this fix, even if something goes bad,
you'll be able to reset by toggling spellcheck disabled -> enabled.

There is some case spellcheck highlight is cleared unexpectedly.

Originally, syntax is set on the plugin load, though,
change to set on every spellcheck triggered to be enabled.
@KSR-Yasuda
Copy link
Author

Updated to store highlight style.
Now it will keep customized spellcheck highlight style.

@cincodenada
Copy link

I ran into this, and this PR seems to have fixed it up - I'm running this branch in my Vim plugin for now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants