Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add showConsoleDebug option #197

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Liooo
Copy link
Contributor

@Liooo Liooo commented Mar 28, 2018

The console warning shown here is usually very useful, but sometimes we want to suppress it (like in production).

This PR:

  • adds showConsoleDebug option, which hides the console warnings when set to false (defaults to true, so this is backward compatible)
  • bumps up the version to 2.1.0

Liooo added 2 commits April 3, 2018 19:07
added showConsoleDebug option
@Liooo Liooo force-pushed the show-console-debug-option branch from 8e5b980 to b75ff1b Compare April 3, 2018 10:39
@Liooo
Copy link
Contributor Author

Liooo commented Apr 3, 2018

@kamilkp resolved conflict, plz merge if it's looking good

@mistic100
Copy link

mistic100 commented May 24, 2018

@kamilkp please merge this feature. In my list I have merged top/bottom borders generating a 1px difference between the actual size and the computed size. This is not problem and should not spam the console. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants