Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add titleFormat #251

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

dojineko
Copy link
Contributor

@dojineko dojineko commented Jan 3, 2018

supply the title suffix feature.

e.g. Happy new year! - My Blog

@kakawait
Copy link
Owner

kakawait commented Jan 3, 2018

@dojineko It's a good idea but I find the current implementation to hardcoded since you decide

<page title> - <site title>

But why not

<site title> - <page title>

I will think about something more customizable like using string format template or something.

@dojineko
Copy link
Contributor Author

dojineko commented Jan 3, 2018

@kakawait
umm... at first, in order to make the order changeable, i was going to implement with string format template.
but i couldn't find such a feature in golang pkg: text/template. so, i implement like this... 😇
the current order, i followed some general sites.

is it better to have parameter like preferSiteTitle, maybe?

@dojineko
Copy link
Contributor Author

dojineko commented Jan 3, 2018

ah! it will solve simply by replace function~
https://gohugo.io/functions/replace/

@dojineko
Copy link
Contributor Author

dojineko commented Jan 3, 2018

@kakawait how about this one?

@dojineko dojineko changed the title add titleDelimiter add titleFormat Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants