Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Windows support #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Windows support #3

wants to merge 1 commit into from

Conversation

mohammed90
Copy link
Collaborator

I ripped the Windows parts out into this PR because it isn't ready and clean. The Windows authentication works and authenticates against the user's password on the system. The issue is with the PTY spawn.

PTY on Windows comes in 2 flavors, both of which have their own issues.

  • One approach is using an external DLL and executable from https://github.com/rprichard/winpty. This works, but the session is not jailed to the user owning the login token. It spawns the session as the user of which the ssh server is running. This is not helpful since most likely it'll be an admin or system user, which isn't safe.
  • The other approach is using the new ConPTY. I had permission issues when I tried this. Windows said something about not being allowed to execute the powershell and CMD executables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant