Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests for ruby-head(3.4.0-dev) bundled irb #184

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Update tests for ruby-head(3.4.0-dev) bundled irb #184

merged 1 commit into from
Apr 12, 2024

Conversation

kachick
Copy link
Owner

@kachick kachick commented Apr 12, 2024

Fixes #183

@kachick kachick changed the title Update tests for ruby-head(3.4 dev) bundled irb Update tests for ruby-head(3.4.0-dev) bundled irb Apr 12, 2024
kachick
kachick commented Apr 12, 2024
View reviewed changes
test/helper.rb
@@ -25,22 +25,46 @@

require_relative '../lib/irb-power_assert'

class Test::Unit::TestCase
# Taken from https://github.com/ruby/irb/blob/ad08152c43d4309ee4dec3bbaf361ffc338c1f46/test/lib/minitest/unit.rb#L461-L495, thank you!
def capture_io
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know test-unit added in 14 years ago... test-unit/test-unit@fd94c6b

kachick
kachick commented Apr 12, 2024
View reviewed changes
test/test_irb_power_assert.rb
@@ -41,9 +35,24 @@ def test_typical_example
EOD

out, err = capture_output do
irb.context.main.irb_pa(%q{"0".class == "3".to_i.times.map {|i| i + 1 }.class})
# We can't handle with the IRB version, because they do not bump version number in development versions.
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/ruby/irb/blob/eb442c4ddab50a519f9f7707e53da3e5a442cc4c/lib/irb/version.rb#L8

@kachick kachick merged commit b544aac into main Apr 12, 2024
8 checks passed
@kachick kachick deleted the fix-ci-failure-in-ruby-head branch April 12, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
🛸
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2024-04-11 - CI failed in ruby-head(3.4.0dev)
1 participant
@kachick