Add securityContext and image registry prefix to the tutorial manifests #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The securityContext parameters should be available into the manifests.
Without it, testing the k8up on the MicroShift environment will raise
warnings:
Warning: would violate PodSecurity "restricted:latest":
seccompProfile (pod or container "mariadb" must set
securityContext.seccompProfile.type to "RuntimeDefault" or "Localhost")
Also added the registry prefix to the images used in the tutorial, to
avoid complication when the runtime environment would not choose
docker.io as a default registry and removed namespace parameter from
secrets manifests, because other manifests in the tutorial does not have
such parameter (so if someone will use other namespace than 'default',
services/deployments will faile because of missing secrets).
danpawlik
force-pushed
the
improve-tutorial
branch
from
3da34b9
to
e720902
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The securityContext parameters should be available into the manifests. Without it, testing the k8up on the MicroShift environment will raise warnings:
Also added the registry prefix to the images used in the tutorial, to avoid complication when the runtime environment would not choose docker.io as a default registry.
Checklist
For Code changes
area:operatorcharts/directory.