Prune resources with ownerReferences if they belong to Stack #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pre
force-pushed
the
feat/prune-with-ownerreference
branch
from
4eebb7a
to
b9ea2c4
Compare
When eg. a controller is the owner of its resources, it also controls the metadata.ownerReferences field. Stack is not able to prune its resources correctly if any resources with ownerReferences are kept. When passing owner_reference: to Stack#apply or Stack#prune, any owned resources matching to given owner_reference will be deemed ours and be pruned.
pre
force-pushed
the
feat/prune-with-ownerreference
branch
from
b9ea2c4
to
8321ce5
Compare
jakolehm
approved these changes
May 6, 2020
| @@ -94,7 +94,7 @@ def prepare_resource(resource, base_resource: nil) | |||
|
|
|||
| # @param client [K8s::Client] | |||
| # @return [Array<K8s::Resource>] | |||
| def apply(client, prune: true, patch: true) | |||
| def apply(client, patch: true, prune: true, owner_reference: nil) | |||
There was a problem hiding this comment.
Not completely happy that we need to add yet-another parameter here but I get why it's needed.
| @@ -140,7 +140,7 @@ def keep_resource?(resource) | |||
| # @param client [K8s::Client] | |||
| # @param keep_resources [NilClass, Boolean] | |||
| # @param skip_forbidden [Boolean] | |||
| def prune(client, keep_resources:, skip_forbidden: true) | |||
| def prune(client, keep_resources:, skip_forbidden: true, owner_reference: nil) | |||
There was a problem hiding this comment.
Maybe add owner_reference to yardocs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When eg. a controller is the owner of its resources, it also controls
the metadata.ownerReferences field. Stack is not able to prune its
resources correctly if any resources with ownerReferences are kept.
When passing owner_reference: to Stack#apply or Stack#prune, any
owned resources matching to given owner_reference will be deemed
ours and be pruned.