Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #456 #462

Closed
wants to merge 3 commits into from
Closed

Fix for #456 #462

wants to merge 3 commits into from

Conversation

hartmark
Copy link
Contributor

@hartmark hartmark commented Jan 24, 2023 •
edited by abatishchev
Loading

Fixes #456.

@hartmark
Copy link
Contributor Author

This will fix #456

@hartmark hartmark mentioned this pull request Jan 24, 2023
Closed
abatishchev
abatishchev requested changes Jan 24, 2023
View reviewed changes
src/JWT/JWT.csproj
@@ -13,6 +13,9 @@
<PropertyGroup Condition="'$(TargetFramework)' == 'net6.0'">
<TargetFrameworkIdentifier>.NETFramework,Version=6.0</TargetFrameworkIdentifier>
</PropertyGroup>
<PropertyGroup Condition="'$(TargetFramework)' == 'net7.0'">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add 7.0 (if we decide so) in a separate PR, see also #451.

@abatishchev
Copy link
Member

Thanks a lot, @hartmark! Can you please rename the PR to give a bit more readable title?

abatishchev
abatishchev requested changes Jan 24, 2023
View reviewed changes
src/JWT/JWT.csproj
@@ -13,6 +13,9 @@
<PropertyGroup Condition="'$(TargetFramework)' == 'net6.0'">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And please bump the version to 10.0.2 so I'll push a fix asap.

@hartmark hartmark closed this Jan 24, 2023
@hartmark hartmark deleted the harre/encode-json-serializer branch January 24, 2023 23:31
@hartmark hartmark restored the harre/encode-json-serializer branch January 24, 2023 23:31
@hartmark hartmark deleted the harre/encode-json-serializer branch January 24, 2023 23:31
@hartmark
Copy link
Contributor Author

Replaced by #463 and #464

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abatishchev abatishchev abatishchev requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decode<JwtHeader> not working
2 participants
@hartmark @abatishchev