-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added option to select serializer #433
Merged
abatishchev
merged 48 commits into
jwt-dotnet:main
from
hartmark:harre/select-serializer
Sep 8, 2022
Merged
Added option to select serializer #433
abatishchev
merged 48 commits into
jwt-dotnet:main
from
hartmark:harre/select-serializer
Sep 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abatishchev
requested changes
Aug 26, 2022
src/JWT.Extensions.DependencyInjection/JWT.Extensions.DependencyInjection.csproj
Show resolved
Hide resolved
abatishchev
requested changes
Aug 26, 2022
It was indeed using the JSON.net serializer now with latest push in the net40 unittest project. |
abatishchev
reviewed
Aug 27, 2022
@abatishchev Any status for this PR? |
Sorry to make you waiting! Will come back to it tonight, if not then shortly. |
abatishchev
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #420
I wanted to create a simple test for checking that the correct class was used as default.
I however noted that all tests returned it was using SystemTextSerializer even on the older dotnets.
See the Serializer_Should_Use_Correct_Default test.