Added some checks for none algorithm #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abatishchev
requested changes
Jun 4, 2022
|
Awesome, thanks much for the contribution and for quickly making the suggested changes too! Please bump the version slightly inside JWT.csproj and it's almost good to go. |
|
Cool, I'll look at bumping the version later tonight. Btw, have your had any chance to look at my other PR for system.text.json #401 |
abatishchev
previously approved these changes
Jun 4, 2022
Will very definitely do! |
|
There, I'm done now :) Reduced some duplicated code in JwtDecoder and reverted WithValidator to previous state |
abatishchev
approved these changes
Jun 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some tests for none algorithm and also implemented that signature MUST not be sent according to spec in: