-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test builds #109
Fix test builds #109
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! The only concern is the code duplication between .NET and Core tests. Once one is changed, another has to be updated manually. Would it be possible to put them in a shared tests project and link from the platform specific projects?
Good call. I forgot that it's possible to reference code files in another project. The latest change looks like it works on the build server. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be better to add those files as links? i.e. https://i-msdn.sec.s-msft.com/dynimg/IC625712.png
I tried that at first, but xUnit wouldn't discover the tests in the project that used links. |
That's odd. Let me try locally, I need to see with my own eyes to fully believe :) Because it shouldn't care since suppose to scan output assembly, not input project. |
Can you please take a look on the latest changes? Would this work, how do you think? |
Never mind, seems to work fine now |
Are you guys going to merge here? |
This PR contains a couple of changes:
Resolves #108