Removing static API #103
Closed
Removing static API #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
abatishchev
commented
May 1, 2017
abatishchev
commented
- Removing static API, tests
|
Nice! 🎉 |
nbarbettini
approved these changes
May 13, 2017
Merged
|
FYI - I rebased this onto master and created a new PR at #107. |
nbarbettini
suggested changes
May 13, 2017
| public void Decode_Should_Decode_Token_To_Json_Encoded_String_With_WebScript_Serializer() | ||
| { | ||
| var serializer = new WebScriptJsonSerializer(); | ||
| JsonWebToken.JsonSerializer = serializer; |
There was a problem hiding this comment.
These tests are now missing. I think we should modify them to use an instance instead of the static JsonWebToken object.
| [Fact] | ||
| public void Should_Encode_Type_With_WebScript_Serializer() | ||
| { | ||
| JsonWebToken.JsonSerializer = new WebScriptJsonSerializer(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.