Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to make this element act a bit like a HTMLMediaElement adding some methods, events and properties (this element will act a bit like a
<video>
element). An attribute must be set to add this feature since I don't want to introduce perf loss when events are not necessary (there is no use in loading the API for nothing).I understand this feature add a bit of bloat so I submit it before adding the test (to avoid working on it further if you think it's not an interesting feature for the common use case).
ESlint & Test config
I tried using eslint with
yarn run lint
but I got errors about missing plugins. I don't want to add additional packages so I don't know if I'm missing somethingAnother problem appears when I try to run test (dunno if it's my env or something I should set up before runing
yarn run test
)