Added ability to specify labels for k8s-objects like DaemonSets and Deployments #2976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I was requested by a client to label all k8s objects of the Jupyterhub helm chart with additional, team specific informations.
Therefore I added a helper function called jupyterhub.determinedLabels to the _helpers.tpl, which extracts given labels from the values.yaml and appends them to the commonLabels.
As far as I see it, this solution overlaps with the pull request #2948 .
As it reaches out not only for the Deployment-objects, but everything which gets labeled via commonLabels, I suppose it is more generic.