-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add locale and other environment variables support for systemd service jupyterhub #414
base: main
Are you sure you want to change the base?
Conversation
@yuvipanda @GeorgianaElena @minrk please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that this PR is centered about the technical change of appending the locale as reported via os.popen("locale")
to environment_for_system_service.conf
, and then making the jupyterhub
registered service run with that file.
I think the idea sounds good, but I'm quite uncertain on how the LANG environment variable functions. Perhaps the feature can be documented more general about setting env vars for the jupyterhub service process and then providing one example that the LANG environment variable for example can be configured via this feature.
I added a lot of small syntax details to the documentation which I also think could be revised to be a bit briefer.
Co-authored-by: Erik Sundell <[email protected]>
no more tests are needed.
#410