Merge pull request #74 from anutosh491/notify

Fix notify socket listener calls
jupyter-xeus · Jun 29, 2024 · d858403 · d858403
2 parents 9cff7bc + a74688e
commit d858403
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 24 deletions.
diff --git a/include/xeus-zmq/xclient_zmq.hpp b/include/xeus-zmq/xclient_zmq.hpp
@@ -58,10 +58,6 @@ namespace xeus
         void wait_for_message();
 
     private:
-
-        void notify_shell_listener(xmessage msg);
-        void notify_control_listener(xmessage msg);
-        void notify_iopub_listener(xpub_message msg);
 
         std::unique_ptr<xclient_zmq_impl> p_client_impl;
     };

diff --git a/src/client/xclient_zmq.cpp b/src/client/xclient_zmq.cpp
@@ -91,21 +91,6 @@ namespace xeus
     {
         p_client_impl->wait_for_message();
     }
-
-    void xclient_zmq::notify_shell_listener(xmessage msg)
-    {
-        p_client_impl->notify_shell_listener(std::move(msg));
-    }
-
-    void xclient_zmq::notify_control_listener(xmessage msg)
-    {
-        p_client_impl->notify_control_listener(std::move(msg));
-    }
-
-    void xclient_zmq::notify_iopub_listener(xpub_message msg)
-    {
-        p_client_impl->notify_iopub_listener(std::move(msg));
-    }
 
     std::unique_ptr<xclient_zmq> make_xclient_zmq(xcontext& context,
                                                 const xconfiguration& config,

diff --git a/src/client/xclient_zmq_impl.hpp b/src/client/xclient_zmq_impl.hpp
@@ -69,11 +69,6 @@ namespace xeus
         void connect();
         void stop_channels();
 
-        void notify_shell_listener(xmessage msg);
-        void notify_control_listener(xmessage msg);
-        void notify_iopub_listener(xpub_message msg);
-        void notify_kernel_dead(bool status);
-
         void wait_for_message();
         void start();
 
@@ -86,6 +81,11 @@ namespace xeus
         void start_heartbeat_thread();
         void poll(long timeout);
 
+        void notify_shell_listener(xmessage msg);
+        void notify_control_listener(xmessage msg);
+        void notify_iopub_listener(xpub_message msg);
+        void notify_kernel_dead(bool status);
+
         using authentication_ptr = std::unique_ptr<xauthentication>;
         authentication_ptr p_auth;