Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing nbformat version #304

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Fix missing nbformat version #304

merged 2 commits into from
Jan 16, 2025

Conversation

fcollonval
Copy link
Member

Fix an inconsistency to allow missing format information at

if "id" in cell and meta["nbformat"] == 4 and meta["nbformat_minor"] <= 4:

This is to aligned with the tolerance implemented a bit later:

return dict(
cells=cells,
metadata=meta.get("metadata", {}),
nbformat=int(meta.get("nbformat", 0)),
nbformat_minor=int(meta.get("nbformat_minor", 0)),
)

@fcollonval fcollonval added the bug Something isn't working label Jan 15, 2025
Copy link
Collaborator

@davidbrochart davidbrochart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fcollonval.

@davidbrochart davidbrochart merged commit 697715e into main Jan 16, 2025
10 checks passed
@davidbrochart davidbrochart deleted the fcollonval-patch-1 branch January 16, 2025 08:10
@davidbrochart
Copy link
Collaborator

In the future, could you make a PR from your fork of jupyter_ydoc?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants