Add streamOutputChange attribute to cell change object
#264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbrochart
force-pushed
the
stream-output-change
branch
from
09e5990 to
c8603b3
Compare
krassowski
reviewed
Aug 22, 2024
| const length = prevText.length - start; | ||
| prevText.delete(start, length); | ||
| }, false); | ||
| removeStreamOutput(index: number, start: number, origin: any = null): void { |
There was a problem hiding this comment.
What are valid types/values for origin?
There was a problem hiding this comment.
In Yjs an origin can be of any type.
Comment on lines
+907
to
+910
| event => | ||
| event.path.length === 3 && | ||
| event.path[0] === 'outputs' && | ||
| event.path[2] === 'text' |
There was a problem hiding this comment.
It's hard to understand this without some concrete example. I guess a comment or a test could help here.
There was a problem hiding this comment.
The event path is an array leading to the changed property, so to access the text property of a cell's stream output, one would do cell['outputs'][output_idx]['text'] and the event path would then be ['outputs', output_idx, 'text']. I'll add a comment 👍
krassowski
approved these changes
Aug 22, 2024
krassowski
changed the title
streamOutputChange attribute to cell change object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See jupyterlab/jupyterlab#16692 (comment).