Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pending_requests #227

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add pending_requests #227

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
68ec61d
Add `pending_requests`
krassowski Apr 11, 2024
2487dc3
Remove empty initializer
krassowski Apr 11, 2024
dc39145
Merge branch 'main' into cell-requests
krassowski Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions jupyter_ydoc/ynotebook.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,12 @@ class YNotebook(YBaseDoc):
"cell_type": str,
"source": YText,
"metadata": YMap,
"pending_requests": YArray[
YMap[
"id": str,
"type": str
]
],
"execution_count": Int | None,
"outputs": [] | None,
"attachments": {} | None
Expand Down Expand Up @@ -100,6 +106,9 @@ def get_cell(self, index: int) -> Dict[str, Any]:
"""
meta = self._ymeta.to_py()
cell = self._ycells[index].to_py()
if "pending_requests" in cell:
# requests are not a part of notebook format, but a run-time only property
del cell["pending_requests"]
cast_all(cell, float, int) # cells coming from Yjs have e.g. execution_count as float
if "id" in cell and meta["nbformat"] == 4 and meta["nbformat_minor"] <= 4:
# strip cell IDs if we have notebook format 4.0-4.4
Expand Down Expand Up @@ -164,6 +173,7 @@ def create_ycell(self, value: Dict[str, Any]) -> Map:
output["text"] = Array(output.get("text", []))
outputs[idx] = Map(output)
cell["outputs"] = Array(outputs)
cell["pending_requests"] = Array()

return Map(cell)

Expand Down
Loading