Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source to dist for sourcemaps #182

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Add source to dist for sourcemaps #182

merged 1 commit into from
Sep 21, 2023

Conversation

vidartf
Copy link
Member

@vidartf vidartf commented Sep 15, 2023

We currently generate and distribute source maps, but not the source that the sourcemaps point to. As exemplified by this warning:

WARNING in ../../node_modules/@jupyter/ydoc/lib/ytext.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '<root>\node_modules\@jupyter\ydoc\src\ytext.ts' file: Error: ENOENT: no such file or directory, open '<root>\node_modules\@jupyter\ydoc\src\ytext.ts'

This change will include the source files in the package dist.

We currently generate and distribute source maps, but not the source that the sourcemaps point to. As exemplified by this warning:

```
WARNING in ../../node_modules/@jupyter/ydoc/lib/ytext.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '<root>\node_modules\@jupyter\ydoc\src\ytext.ts' file: Error: ENOENT: no such file or directory, open '<root>\node_modules\@jupyter\ydoc\src\ytext.ts'
```

This change will include the source files in the package dist.
@welcome
Copy link

welcome bot commented Sep 15, 2023

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@vidartf
Copy link
Member Author

vidartf commented Sep 15, 2023

c.f. jupyterlab/jupyterlab#14028

Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vidartf

@fcollonval fcollonval merged commit 3bbafab into main Sep 21, 2023
9 of 10 checks passed
@welcome
Copy link

welcome bot commented Sep 21, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@fcollonval fcollonval deleted the vidartf-patch-1 branch September 21, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants