Skip to content

Commit

Permalink
More cleanup (#1077)
Browse files Browse the repository at this point in the history
* more test cleanup

* add codecov badge

* remove unused env var
  • Loading branch information
blink1073 authored Nov 20, 2022
1 parent 1e18aae commit fe87f69
Show file tree
Hide file tree
Showing 5 changed files with 36 additions and 29 deletions.
22 changes: 0 additions & 22 deletions .github/workflows/check-release.yml

This file was deleted.

15 changes: 15 additions & 0 deletions .github/workflows/downstream.yml
Original file line number Diff line number Diff line change
Expand Up @@ -100,3 +100,18 @@ jobs:
uses: jupyterlab/maintainer-tools/.github/actions/downstream-test@v1
with:
package_name: jupyter_server_terminals

downstream_check: # This job does nothing and is only used for the branch protection
if: always()
needs:
- jupyterlab
- jupyter_server_terminals
- jupyterlab_server
- notebook
- nbclassic
runs-on: ubuntu-latest
steps:
- name: Decide whether the needed jobs succeeded or failed
uses: re-actors/alls-green@release/v1
with:
jobs: ${{ toJSON(needs) }}
1 change: 0 additions & 1 deletion .github/workflows/integration-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ jobs:
run: |
hatch run cov:integration
integration_check: # This job does nothing and is only used for the branch protection
if: always()
needs:
Expand Down
26 changes: 20 additions & 6 deletions .github/workflows/python-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
pip install codecov
codecov
pre-commit:
pre_commit:
name: pre-commit
runs-on: ubuntu-latest
steps:
Expand Down Expand Up @@ -96,7 +96,6 @@ jobs:
only_create_file: 1
- name: Run the unit tests
run: |
export PIP_CONSTRAINT="./contraints_file.txt"
hatch run test:nowarn || hatch run test:nowarn --lf
test_prereleases:
Expand All @@ -110,8 +109,7 @@ jobs:
python_version: "3.11"
- name: Run the tests
run: |
export PIP_PRE=1
hatch run test:nowarn || hatch run test:nowarn --lf
PIP_PRE=1 hatch run test:nowarn || hatch run test:nowarn --lf
make_sdist:
name: Make SDist
Expand All @@ -134,6 +132,21 @@ jobs:
package_spec: .
test_command: hatch run test:test || hatch run test:test --lf

check_release:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
- name: Base Setup
uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
- name: Install Dependencies
run: |
pip install -e .
- name: Check Release
uses: jupyter-server/jupyter_releaser/.github/actions/check-release@v2
with:
token: ${{ secrets.GITHUB_TOKEN }}

check_links:
name: Check Links
runs-on: ubuntu-latest
Expand All @@ -143,15 +156,16 @@ jobs:
- uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
- uses: jupyterlab/maintainer-tools/.github/actions/check-links@v1

python_tests_check: # This job does nothing and is only used for the branch protection
tests_check: # This job does nothing and is only used for the branch protection
if: always()
needs:
- build
- pre-commit
- pre_commit
- test_docs
- test_minimum_versions
- test_prereleases
- check_links
- check_release
- test_sdist
runs-on: ubuntu-latest
steps:
Expand Down
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Jupyter Server

[![Build Status](https://github.com/jupyter-server/jupyter_server/actions/workflows/python-tests.yml/badge.svg?query=branch%3Amain++)](https://github.com/jupyter-server/jupyter_server/actions/workflows/python-tests.yml/badge.svg?query=branch%3Amain++)
[![codecov](https://codecov.io/gh/jupyter-server/jupyter_server/branch/main/graph/badge.svg?token=S9WiBg2iL0)](https://codecov.io/gh/jupyter-server/jupyter_server)
[![Documentation Status](https://readthedocs.org/projects/jupyter-server/badge/?version=latest)](http://jupyter-server.readthedocs.io/en/latest/?badge=latest)

The Jupyter Server provides the backend (i.e. the core services, APIs, and REST endpoints) for Jupyter web applications like Jupyter notebook, JupyterLab, and Voila.
Expand Down

0 comments on commit fe87f69

Please sign in to comment.