Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run npm pack if there are public packages in workspace #522

Merged
merged 3 commits into from
Oct 17, 2023

Conversation

fcollonval
Copy link
Member

@jtpio
Copy link
Member

jtpio commented Aug 24, 2023

Fix issue seen in jupyterlab-contrib/jupyterlab-favorites#15

Shouldn't the top-level package.json in https://github.com/jupyterlab-contrib/jupyterlab-favorites be picked up since it does not have a private field?

Usually the extension should also be published to npm by default, so maybe this indicates there is an issue somewhere else?

@fcollonval
Copy link
Member Author

fcollonval commented Aug 24, 2023

The releaser picked up the top repo correctly. But as a workspace listing the ui-test was present it also tries to list all public packages part of the workspace requiring packaging. However in that specific case there is no public package in the workspace; hence the bug (it runs npm pack with no argument in a folder that is not a npm package) that this PR fixes.

@jtpio
Copy link
Member

jtpio commented Aug 24, 2023

OK thanks for providing the extra context.

Maybe this case should be put under tests? Or we add a print / info statement if workspaces is defined but no packages will be published? In case there is a misconfiguration issue.

Otherwise the change looks good 👍

@fcollonval
Copy link
Member Author

we add a print / info statement if workspaces is defined but no packages will be published?

Thanks for the suggestion @jtpio; I added a log message in ee81639

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 8bd91cc into main Oct 17, 2023
18 checks passed
@blink1073 blink1073 deleted the fcollonval-patch-1 branch October 17, 2023 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants