-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only run npm pack if there are public packages in workspace #522
Conversation
Shouldn't the top-level Usually the extension should also be published to npm by default, so maybe this indicates there is an issue somewhere else? |
The releaser picked up the top repo correctly. But as a workspace listing the ui-test was present it also tries to list all public packages part of the workspace requiring packaging. However in that specific case there is no public package in the workspace; hence the bug (it runs |
OK thanks for providing the extra context. Maybe this case should be put under tests? Or we add a print / info statement if Otherwise the change looks good 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fix issue seen in jupyterlab-contrib/jupyterlab-favorites#15