Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated job definition models, handlers, and scheduler apis #45

Merged
merged 5 commits into from
Oct 5, 2022
Merged

Updated job definition models, handlers, and scheduler apis #45

merged 5 commits into from
Oct 5, 2022

Conversation

3coins
Copy link
Collaborator

@3coins 3coins commented Sep 26, 2022

  • Updated models to support job definition
  • Added scheduler apis for job definitions
  • Added handlers for job definition REST apis

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch 3coins/jupyter-scheduler/job-definition-models

@3coins 3coins marked this pull request as ready for review September 26, 2022 17:25
@3coins 3coins requested a review from ellisonbg September 26, 2022 17:25
@3coins 3coins force-pushed the job-definition-models branch from 8a89ec0 to afbf3f6 Compare September 28, 2022 03:15
@3coins
Copy link
Collaborator Author

3coins commented Sep 28, 2022

Rebased from main, added async apis support.

@3coins 3coins added the enhancement New feature or request label Sep 29, 2022
@dlqqq dlqqq self-requested a review September 29, 2022 18:11
@JasonWeill
Copy link
Collaborator

Out of curiosity, what is the set of possible values for timezone? Are we using UNIX time zone definitions like America/Los_Angeles, for example?

@3coins
Copy link
Collaborator Author

3coins commented Oct 1, 2022

Out of curiosity, what is the set of possible values for timezone? Are we using UNIX time zone definitions like America/Los_Angeles, for example?

Correct.

dlqqq
dlqqq requested changes Oct 3, 2022
View reviewed changes
jupyter_scheduler/scheduler.py Show resolved Hide resolved
jupyter_scheduler/models.py Outdated Show resolved Hide resolved
jupyter_scheduler/scheduler.py Outdated Show resolved Hide resolved
jupyter_scheduler/scheduler.py Outdated Show resolved Hide resolved
jupyter_scheduler/scheduler.py Show resolved Hide resolved
jupyter_scheduler/orm.py Outdated Show resolved Hide resolved
@JasonWeill JasonWeill mentioned this pull request Oct 4, 2022
Merged
@3coins 3coins force-pushed the job-definition-models branch from afbf3f6 to 8806290 Compare October 4, 2022 05:48
ellisonbg
ellisonbg requested changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@ellisonbg ellisonbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looks good, left some inline comments.

jupyter_scheduler/models.py Outdated Show resolved Hide resolved
jupyter_scheduler/models.py Outdated Show resolved Hide resolved
jupyter_scheduler/models.py Show resolved Hide resolved
jupyter_scheduler/orm.py Outdated Show resolved Hide resolved
jupyter_scheduler/scheduler.py Show resolved Hide resolved
jupyter_scheduler/scheduler.py Outdated Show resolved Hide resolved
@ellisonbg ellisonbg mentioned this pull request Oct 4, 2022
Closed
This was referenced Oct 4, 2022
Closed
Open
@dlqqq

This comment was marked as resolved.

Sign in to view
@ellisonbg

This comment was marked as resolved.

Sign in to view
@3coins

This comment was marked as resolved.

Sign in to view
@dlqqq

This comment was marked as resolved.

Sign in to view
@dlqqq

This comment was marked as resolved.

Sign in to view
@3coins 3coins force-pushed the job-definition-models branch 2 times, most recently from 5a5ae3e to 1653912 Compare October 5, 2022 00:55
@3coins
Copy link
Collaborator Author

3coins commented Oct 5, 2022

Made all updates as per feedback. Merging the changes.

@3coins 3coins force-pushed the job-definition-models branch from 1653912 to a4785d8 Compare October 5, 2022 02:33
@3coins 3coins merged commit 802a83a into jupyter-server:main Oct 5, 2022
@3coins 3coins deleted the job-definition-models branch October 5, 2022 02:59
@JasonWeill JasonWeill mentioned this pull request Oct 19, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlqqq dlqqq dlqqq requested changes

@ellisonbg ellisonbg ellisonbg requested changes

@JasonWeill JasonWeill JasonWeill approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@3coins @JasonWeill @dlqqq @ellisonbg