-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds custom config to show/hide host usage info #210
Conversation
Thanks for submitting your first pull request! You are awesome! 🤗 |
Thank you for opening this, @pinksi! I agree that on k8s / containerized systems, this is just a distraction that doesn't meaningfully add anything. I don't have a full enough understanding of the TS parts, but this mostly lgtm! If nobody else reviews in a week or so, I will test locally and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Left a small inline comment, otherwise looks good!
Thanks @jtpio and @yuvipanda for the review. I accidentally closed this PR, so reopened it again. |
This is now available in version |
Thanks a lot, @jtpio! |
Objective
This PR includes the changes to add a custom configuration to show or hide the Host CPU and Host Virtual Memory information (Issue: #209) . It is added as a config parameter, and can be set as:
c.ResourceUseDisplay.show_host_usage=False
(if you want to hide the host usage info, default is set as True)How to test
Follow the set up process from
contributing.md
or use the following commands:When you click the sidebar or tachometer, you should only see the Kernel usage as shown below:
When you set the
show_host_usage=True
, you should see all the info.