Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the version check invocation in install.ps1 #2708

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change the version check invocation in install.ps1 #2708

wants to merge 1 commit into from

Commits on Jan 10, 2022

  1. Change the version check invocation in install.ps1 

    When install.ps1 is executed inside MSYS (or cygwin I suspect) cmd
is a shell script that invokes the real cmd.  But in install.ps1 it
tries to open this shell script instead of executing it.

AFAICT the only reason to use cmd /c is to capture stderr because
there is a bug with powersehll; but fzf prints the version information
on stdout so we don't need to care about stderr.  So we can just call
the binary directly.  This avoids the cmd issues.
    @tomrittervg
    tomrittervg committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    71c005b View commit details
    Browse the repository at this point in the history