Fix useWindowSize not updating on orientation change #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 509e55f The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
k-melnychuk
force-pushed
the
hotfix/use-window-size-fix
branch
from
5617a83
to
a4d71c1
Compare
k-melnychuk
force-pushed
the
hotfix/use-window-size-fix
branch
from
a4d71c1
to
69cb7b1
Compare
k-melnychuk
force-pushed
the
hotfix/use-window-size-fix
branch
from
69cb7b1
to
509e55f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #530
There are a few changes though:
orietationchangeevent ) I had to add support forScreenOrientationinterface touseEventisteneruseWindowSizeto handle orientationchangeeventuseWindowSizeto not render multiple times even if windowresizeevent or orientationchangeevent fires multiple times unless window width or height change