improvement: omit useDebounceCallback func arg from dependency array #501
+61
−22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvement
Problem
debouncedIncrement
anddebouncedFn
will always create new reference every re-render. this will be dangerous if this debounced function is passed to any react hooks dependency arrayoptions
object, the user's providedoptions
object also not necessarily memoized, so we can just pass it's values to dependency array instead of the object reference itselfSolution
func
intouseRef
, so we dont need to pass it to theuseMemo
dependency arrayoptions
in theuseMemo
dependency arrayFix
Current behavior
isPending()
always returntrue
, it is onlyfalse
on first renderExpectation
based on type comments