Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add onStop to useCountdown hook #484

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

samyarkd
Copy link

Every time I used useCountdown I had to set a timeout for when the count is stopped, it would much easier if we have this inside the hook, it would be much cleaner.

Every time I used useCountdown I had to set a timeout for when the count is stopped, it would much easier if we have this inside the hook, it would be much cleaner.
Copy link

changeset-bot bot commented Feb 10, 2024

⚠️ No Changeset found

Latest commit: b8b91ae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@samyarkd
Copy link
Author

please let me know if I have to add jsDoc to the hook in case of approval.

@juliencrn juliencrn added the enhancement Improvements label Feb 20, 2024
@juliencrn
Copy link
Owner

Hi @samyarkd,
Thanks for that PR.
Yes, the JSDoc is more than welcome, and a unit-test too.
However, the PR does not compile yet.

@samyarkd
Copy link
Author

samyarkd commented Mar 7, 2024

added a unit test and modified the jsDocs 👍 also created a function to stop the countdown.

@samyarkd
Copy link
Author

@juliencrn congratulations on the V3, i noticed there has been a couple changes in the hook so modified the changes according to the V3 so there are no conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants