Add valid svg attributes and allow empty attributes #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some lines have changes due to removed whitespaces at the end.
Ridvanovskyy
suggested changes
Jul 24, 2020
| @@ -452,7 +736,7 @@ function getCSSValue(el, prop, unit) { | |||
| } | |||
|
|
|||
| function getAnimationType(el, prop) { | |||
| if (is.dom(el) && !is.inp(el) && (getAttribute(el, prop) || (is.svg(el) && el[prop]))) return 'attribute'; | |||
| if (is.dom(el) && !is.inp(el) && (getAttribute(el, prop) || (is.svg(el) && arrayContains(validSvgAttributes, prop)))) return 'attribute'; | |||
There was a problem hiding this comment.
This is good improvement for .set() and animatable values. But you affect some not animatable values like class. Need to add a check for preventing animating such attributes.
…vg-attributes # Conflicts: # src/index.js
juliangarnier
added a commit
that referenced
this pull request
Aug 19, 2022
juliangarnier
added a commit
that referenced
this pull request
Aug 19, 2022
juliangarnier
added a commit
that referenced
this pull request
Aug 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a list of all valid SVG Attributes (https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute) and allows us to set own attributtes with JavaScript e. g. for initialisation.
Now
With this PR
JavaScript