Match by MAC in Netplan for LXD VMs #17327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvinuesa
reviewed
May 3, 2024
There was a problem hiding this comment.
Code LGTM, although QA doesn't pass on my manual cloud: the container never gets an address:
juju status
Model Controller Cloud/Region Version SLA Timestamp
m c manual-multipass/default 3.4.3.1 unsupported 17:10:25+02:00
App Version Status Scale Charm Channel Rev Exposed Message
ubuntu waiting 0/1 ubuntu latest/stable 24 no waiting for machine
Unit Workload Agent Machine Public address Ports Message
ubuntu/0 waiting allocating 0/lxd/0 waiting for machine
Machine State Address Inst id Base AZ Message
0 started 10.215.127.216 manual:10.215.127.216 [email protected] Manually provisioned machine
0/lxd/0 pending juju-e594e5-0-lxd-0 [email protected] Container started
I don't see any error on the logs though.
SimonRichardson
approved these changes
May 14, 2024
manadart
force-pushed
the
3.4-lxd-vm-in-machine
branch
from
e9c7ce6
to
e3c0167
Compare
|
/merge |
1 similar comment
|
/merge |
|
/build |
|
/merge |
SimonRichardson
approved these changes
May 17, 2024
|
/merge |
manadart
force-pushed
the
3.4-lxd-vm-in-machine
branch
from
e3c0167
to
7cff8a8
Compare
|
/merge |
1 similar comment
|
/merge |
address, when we create LXD VMs on-machine. This mimics the behaviour for the KVM provider. The option setting is simplified to remove multiple negative clauses, and the KVM broker made explicit in it's use of the option.
manadart
force-pushed
the
3.4-lxd-vm-in-machine
branch
from
7cff8a8
to
729c2b0
Compare
|
/merge |
Closed
Merged
jujubot
added a commit
that referenced
this pull request
May 29, 2024
#17438 Merge 3.6 Conflicts were mainly due to previous series to base work (delete code in 4.0 target). The secrets conflict was code moved to the domain service. The deployrepository change essentially brought in new code from 3.6 Also, the juju charm repo has since been brought in tree so recent changes from upstream needed to be copied down. #17061 [from jack-w-shaw/fix_regression_local_pylib…](65c9f60) #17079 [from jack-w-shaw/fix_another_regression_wit…](501fcd8) #17136 [from benhoyt/pebble-v1.1.1](a0e0041) #17221 [from jameinel/2.9-cla-workflow](58bc12d) #17283 [from Aflynn50/fix-terraform-ci-2.9](cfad18e) #17356 [from jack-w-shaw/use_base_in_bootstrap_config](aeec03c) #17313 [from cderici/gce-remove-unused-region](ec7d269) #17328 [from jack-w-shaw/Remove_LegacyKubernetesSeries](51a0f74) #17331 [from jack-w-shaw/Replace_BootstrapSeries_wi…](439fd0a) #17340 [from ycliuhw/fix/lp-2064772](322312b) #17353 [from cderici/fix-controllercharm-prometheus…](a5c211d) #17365 [from wallyworld/fix-secret-watcher](804e5b0) #17309 [from babakks/css-8360/apply-client-in-simpl…](62599ce) #17370 [from cderici/fix-controllercharm-prometheus…](48d82f2) #17366 [from hmlanigan/panic-nil-pointer](57070f7) #17380 [from jack-w-shaw/bump_os_patch](78004ae) #17382 [from hmlanigan/not-equal](ad87b5a) #17388 [from jack-w-shaw/fix_broken_test](1ff63ec) #17400 [from jack-w-shaw/remove_used_code](5be5c43) #17327 [from manadart/3.4-lxd-vm-in-machine](c95ac79) #17415 [from hpidcock/fix-non-rootless](ecabfa8) #17425 [from tmihoc/JUJU-6065_add_credential_outdat…](1a89726) #17427 [from wallyworld/delete-old-acceptancetests](7f169f3) ``` # Conflicts: # acceptancetests/assess # acceptancetests/deploy_stack.py # acceptancetests/jujupy/k8s_provider/aks.py # acceptancetests/jujupy/k8s_provider/eks.py # apiserver/facades/agent/secretsmanager/secrets.go # apiserver/facades/agent/secretsmanager/secrets_test.go # apiserver/facades/client/application/deployrepository.go # apiserver/facades/client/application/deployrepository_test.go # apiserver/watcher.go # caas/kubernetes/provider/application/application_test.go # caas/kubernetes/provider/k8s_test.go # cmd/juju/commands/bootstrap_test.go # container/kvm/kvm.go # core/base/base.go # environs/bootstrap.go # environs/bootstrap/bootstrap_test.go # go.mod # go.sum # internal/bundle/changes/handlers.go # internal/provider/common/bootstrap_test.go # juju/testing/conn.go # testing/factory/factory.go # tests/suites/static_analysis/copyright.sh ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some time ago, we observed that 22.04 LXD containers were sometimes getting NICs with different MAC addresses to what the on-machine broker was configuring.
At this time we changed the behaviour of the cloud-init Netplan generation to match NICs by name instead of MAC when provisioning LXD containers.
The linked bug describes network configuration failures for VMs on LXD due to being unable to match by name. This is because interfaces get the kernel generated names (such as "ens5s0") instead of the configured "eth0".
Here we recruit matching by name specifically for LXD containers. LXD VMs and VMs provisioned by the KVM broker use MAC matching, which fixes the issue.
QA steps
I tested on MAAS, but the manual provider should work.
juju add-model work.juju add-machine.juju deploy ubuntu --to lxd:0 --constraints virt-type=virtual-machine.Documentation changes
None.
Links
Launchpad bug: https://bugs.launchpad.net/juju/+bug/2064515
Jira card: JUJU-5981