Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AR Foundation instructions and fix missing XRmanifest.androidlib #911

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

timbotimbo
Copy link
Collaborator

@timbotimbo timbotimbo commented Jan 3, 2024

Description

If your Unity project uses XR Plugin management 4.4 or higher, you get an error when building on android. #844

Project with path 'xrmanifest.androidlib' could not be found in project ':unityLibrary

You need to add an include to settings.gradle to handle this.

Changes

  • Document including xrmanifest.androidlib in the readme.
include ":unityLibrary:xrmanifest.androidlib"
  • Update outdated AR Foundation setup in the readme.
    You don't need to manually include all the .aar files in gradle anymore.
  • Android export now tries to automatically include xrmanifest.androidlib in settings.gradle

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

This PR is somewhat related to #908, as ARFoundation will crash on recent unity versions without that fix.

Copy link

@vanomak vanomak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@CristovoXDGM
Copy link

@juicycleff please merge this, we need updates for this current version of the plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants