Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify InfiniteScrollListener #17

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Simplify InfiniteScrollListener #17

wants to merge 2 commits into from

Conversation

Jaimies
Copy link

@Jaimies Jaimies commented Dec 2, 2019 •
edited
Loading

It appears that you don't need to store visibleItemCount, totalItemCount and firstVisibleItem as member variables of the listener, since they are recalculated on every invocation of onScrolled and aren't used anywhere else.
Also, I guess it is a good coding practice to store VISIBLE_THRESHOLD as a const val in the listener's companion object

@Jaimies Jaimies changed the title Simplify infinite scroll listener Simplify InfiniteScrollListener Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Jaimies