fix: refactor to latest asdf best practices #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jthegedus
commented
Jul 4, 2022
test/banned_commands.bats
Outdated
| # followed by an underscore (indicating it's a variable and not a | ||
| # command). | ||
| for cmd in "${banned_commands[@]}"; do | ||
| run bash -c "grep -nHR --include \*.bash --include \*.sh '$cmd' . \ |
There was a problem hiding this comment.
The listed dirs to check does not seem to be working as expected. It is not capturing banned commands in some of the bin/ commands. Need to fix.
There was a problem hiding this comment.
it is because of the --include as the files in bin and lib do not have extensions being grepped for
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
banned_commands.batsfrom asdf core to enforce POSIX and cross platform functionality as best as possiblelib/*dirMotivation and Context
Types of changes
Usage examples
How Has This Been Tested?
Checklist: