Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support drag and drop for array item #1526

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

support drag and drop for array item #1526

wants to merge 6 commits into from

Conversation

skyshore2001
Copy link

Q A
Is bugfix? ❌
New feature? ✔️
Is backward-compatible? ✔️
Tests pass? N.A.
Fixed issues comma-separated list of tickets # fixed by the PR, if any
Updated README/docs? ✔️
Added CHANGELOG entry? ✔️

1
2

@germanbisurgi
Copy link
Collaborator

Hi, @skyshore2001, thanx for investing your time in this project. Ich checked your branch and played with an example form with arrays. I can say it works like described, and its backward compatible. The only 2 things think i missed was a handle item, like an drag icon on similar, especially for the table editor instead of activating with double click every time i wanted to drag and drop and an "dragging" feedback.

Since JSONEditor change a little bit in the last days, it is necessary to merge the current main branch into your branch before merging, because the test will not pass otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@germanbisurgi germanbisurgi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@skyshore2001 @germanbisurgi