Add stringify method to mirror parse #214
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it would help if we had more documentation on this, maybe a description for the PR to clarify? The code looks like the goal is to take the output from |
|
Yes. |
|
Sorry, to which question? |
|
Yes to all of them. |
wesleytodd
approved these changes
Nov 20, 2024
| @@ -169,7 +169,7 @@ export interface StringifyOptions { | |||
| } | |||
|
|
|||
| /** | |||
| * Stringify a set of cookies into a `Cookie` header string. | |||
| * Stringifies an object into a HTTP `Cookie` header. | |||
There was a problem hiding this comment.
Suggested change
| * Stringifies an object into a HTTP `Cookie` header. | |
| * Stringifies an object into an HTTP `Cookie` header. |
jonchurch
reviewed
Nov 22, 2024
jonchurch
approved these changes
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the work from #200, adding methods that mirror the existing methods so someone can easily understand
parse/stringifyand (in another PR)serialize/deserialize.