Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ongoing promise in async iterator return() method #269

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Update ongoing promise in async iterator return() method #269

merged 1 commit into from
Feb 13, 2024

Conversation

MattiasBuelens
Copy link
Contributor

Fixes #268.

@domenic domenic merged commit 940ff34 into jsdom:master Feb 13, 2024
3 checks passed
@MattiasBuelens MattiasBuelens deleted the async-iterator-return-update-ongoing branch February 13, 2024 09:11
@MattiasBuelens MattiasBuelens mentioned this pull request Apr 23, 2024
Merged
domenic pushed a commit to whatwg/streams that referenced this pull request Apr 24, 2024
@MattiasBuelens
Meta: roll reference implementation web platform tests
4a2ba76 
Notably, this includes tests for promise resolution order of async iterators in the reference implementation. This requires updating webidl2js.

See whatwg/webidl#1387, web-platform-tests/wpt#44456, and jsdom/webidl2js#269 for context.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update ongoing promise in async iterator return() method
2 participants
@MattiasBuelens @domenic