Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof-of-concept for adding the definition location (from source where
attr
,attr_reader
,attr_accessor
orattr_writer
was called) into allattr
-style methods, to address the missing information reported in #8079.A benchmark is included, and shows how severely this impacts the creation of attrs, due to the stack walking involved:
Using a specialized call site would make this largely free, similar to how #8170 avoids frame access for
block_given?
but this example demonstrates one (slow) way to solve the bug.